Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEWEL-743] Expose position provider in PopupContainer #2929

Closed
wants to merge 1 commit into from
Closed

[JEWEL-743] Expose position provider in PopupContainer #2929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platform/jewel/ui/api/ui.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ public final class org/jetbrains/jewel/ui/component/PlatformIconKt {
}

public final class org/jetbrains/jewel/ui/component/PopupContainerKt {
public static final fun PopupContainer (Lkotlin/jvm/functions/Function0;Landroidx/compose/ui/Alignment$Horizontal;Landroidx/compose/ui/Modifier;Lorg/jetbrains/jewel/ui/component/styling/PopupContainerStyle;Landroidx/compose/ui/window/PopupProperties;Lkotlin/jvm/functions/Function2;Landroidx/compose/runtime/Composer;II)V
public static final fun PopupContainer (Lkotlin/jvm/functions/Function0;Landroidx/compose/ui/Alignment$Horizontal;Landroidx/compose/ui/Modifier;Lorg/jetbrains/jewel/ui/component/styling/PopupContainerStyle;Landroidx/compose/ui/window/PopupProperties;Landroidx/compose/ui/window/PopupPositionProvider;Lkotlin/jvm/functions/Function2;Landroidx/compose/runtime/Composer;II)V
}

public final class org/jetbrains/jewel/ui/component/PopupManager {
Expand Down
9 changes: 5 additions & 4 deletions platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PopupContainer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.shadow
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.window.Popup
import androidx.compose.ui.window.PopupPositionProvider
import androidx.compose.ui.window.PopupProperties
import org.jetbrains.jewel.foundation.Stroke
import org.jetbrains.jewel.foundation.modifier.border
Expand All @@ -24,15 +25,15 @@ public fun PopupContainer(
modifier: Modifier = Modifier,
style: PopupContainerStyle = JewelTheme.popupContainerStyle,
popupProperties: PopupProperties = PopupProperties(focusable = true),
content: @Composable () -> Unit,
) {
val popupPositionProvider =
popupPositionProvider: PopupPositionProvider =
AnchorVerticalMenuPositionProvider(
contentOffset = style.metrics.offset,
contentMargin = style.metrics.menuMargin,
alignment = horizontalAlignment,
density = LocalDensity.current,
)
),
content: @Composable () -> Unit,
) {
Popup(
popupPositionProvider = popupPositionProvider,
onDismissRequest = onDismissRequest,
Expand Down
Loading