Merge pull request #198 from JetBrains/pre-130

prepare 1.30
JetBrains · Dec 27, 2023 · f251dce · f251dce
2 parents cfb7e5c + 79840c6
commit f251dce
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "kotlin-playground",
-  "version": "1.29.0",
+  "version": "1.30.0",
   "description": "Self-contained component to embed in websites for running Kotlin code",
   "keywords": [
     "kotlin",

diff --git a/src/executable-code/index.js b/src/executable-code/index.js
@@ -116,7 +116,7 @@ export default class ExecutableCode {
         crosslinkValue === 'disabled' || // disabled by developer
         highlightOnly || // highlighted only not worked in...
         ( // Unsupported external deps
-          (jsLibs && jsLibs.length > 0) ||
+          (jsLibs && !!jsLibs.size) ||
           (hiddenDependencies && hiddenDependencies.length > 0)
         )
       )

diff --git a/tests/crosslink.e2e.ts b/tests/crosslink.e2e.ts
@@ -52,21 +52,15 @@ test.describe('open in playground', () => {
       printlnCode('Hello, World'),
     ));
 
-  test('no link for js-libs', ({ page }) => {
-    test.fixme(
-      true,
-      "Test doesn't work, BUG in code! jsLibs.length -> jsLibs.size",
-    );
-
-    return checkCrosslink(
+  test('no link for js-libs', ({ page }) =>
+    checkCrosslink(
       page,
       {
         'data-target-platform': 'js',
         'data-js-libs': 'https://somescript.js',
       },
       printlnCode('Hello, World!'),
-    );
-  });
+    ));
 
   test('no link for hidden deps', ({ page }) =>
     checkCrosslink(