KTL-1478 Swift Export in Kotlin Playground: support new target in Widget #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpachoo
force-pushed
the
ktl-1478-swift-export
branch
from
a68840e
to
90d868a
Compare
krutilov
approved these changes
May 21, 2024
zoobestik
reviewed
May 21, 2024
| @@ -34,6 +34,9 @@ export const API_URLS = { | |||
| case TargetPlatforms.JUNIT: | |||
| url = `${this.server}/api/${version}/compiler/test`; | |||
| break; | |||
| case TargetPlatforms.SWIFT_EXPORT: | |||
| url = `${this.server}/api/${version}/${TargetPlatforms.SWIFT_EXPORT.id}/compiler/translate?compiler=swift-export`; | |||
There was a problem hiding this comment.
Why we use translate?compiler= is it based on jscode?
There was a problem hiding this comment.
Yeah, it's based on JS. Here's more details JetBrains/kotlin-compiler-server#723
There was a problem hiding this comment.
But, you create for ex. iframe for executing, and so on:
this.jsExecutor.reloadIframeScripts(jsLibs, this.getNodeForMountIframe(), targetPlatform);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KTL-1478/Swift-Export-in-Kotlin-Playground-support-new-target-in-Widget
How does it look like:
