QD-9962 accept push-fixes for prMode #424
Merged
+29,097
−29,102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiIurko
force-pushed
the
iurko/add-fixes-in-pr-mode
branch
from
bd7c72e to
b44138e
Compare
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
tiulpin
force-pushed
the
iurko/add-fixes-in-pr-mode
branch
from
fdf7b94 to
98b6ef4
Compare
tiulpin
force-pushed
the
iurko/add-fixes-in-pr-mode
branch
from
98b6ef4 to
95117ce
Compare
tiulpin
approved these changes
Dec 16, 2024
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of the scoped script, Qodana does not have any issues applying fixes in pr-mode. The case of local-changes script will be handled on the linter side.
This pull request includes several changes aimed at improving the functionality and organization of the
scanmodule, as well as updating the version of a related extension. The most important changes include removing unused imports, modifying thepushQuickFixesfunction to handle cherry-picking commits, and updating the version in thevss-extension.dev.jsonfile.Code cleanup and organization:
scan/src/main.ts: Removed unused import ofgithuband the constantNONE.Functionality improvements:
scan/src/main.ts: Removed the check forpushFixesinprModeto simplify themainfunction.scan/src/utils.ts: Modified thepushQuickFixesfunction to handle cherry-picking commits when inBRANCHmode.