⚡ QD-9730 Switch to scoped script for incremental analysis.

core/ide.go

@@ -190,8 +190,8 @@ func GetIdeArgs(opts *QodanaOptions) []string {
 		if opts.DiffEnd != "" && opts.Script == "default" {
 			arguments = append(arguments, "--diff-end", opts.DiffEnd)
 		}
-		if opts.ForceDiffMode && opts.Script == "default" {
-			arguments = append(arguments, "--force-diff-analysis-mode")
+		if opts.ForceLocalChangesScript && opts.Script == "default" {
+			arguments = append(arguments, "--force-local-changes-script")
 		}
 
 		if opts.AnalysisId != "" {

core/run_scenario.go

@@ -16,11 +16,7 @@
 
 package core
 
-import (
-	"github.com/JetBrains/qodana-cli/v2024/platform"
-	log "github.com/sirupsen/logrus"
-	"strings"
-)
+import "github.com/JetBrains/qodana-cli/v2024/platform"
 
 const (
 	runScenarioDefault      = "default"
@@ -32,19 +28,17 @@ const (
 type RunScenario = string
 
 func (o *QodanaOptions) determineRunScenario(hasStartHash bool) RunScenario {
-	isDotNet := Prod.Code == platform.QDNET || strings.Contains(o.Linter, "dotnet")
-
+	if o.ForceLocalChangesScript || o.Script == "local-changes" {
+		platform.WarningMessage("Using local-changes script is deprecated, please switch to other mechanisms of incremental analysis. Further information - https://www.jetbrains.com/help/qodana/analyze-pr.html")
+	}
 	switch {
-	case o.ForceDiffMode && !hasStartHash:
-		log.Fatal("Cannot run any diff script without --diff-start/--commit")
-		panic("Unreachable")
 	case o.FullHistory:
 		return runScenarioFullHistory
 	case !hasStartHash:
 		return runScenarioDefault
-	case o.ForceDiffMode || isDotNet:
-		return runScenarioScoped
-	default:
+	case o.ForceLocalChangesScript:
 		return runScenarioLocalChanges
+	default:
+		return runScenarioScoped
 	}
 }

core/run_scenario_test.go

@@ -89,18 +89,18 @@ func TestQodanaOptions_determineRunScenario(t *testing.T) {
 				hasStartHash:  true,
 				productCode:   platform.QDJVM,
 			},
-			want: runScenarioLocalChanges,
+			want: runScenarioScoped,
 		},
 		{
 			name: "forced script",
 			args: args{
 				qodanaOptions: &platform.QodanaOptions{
-					ForceDiffMode: true,
+					ForceLocalChangesScript: true,
 				},
 				hasStartHash: true,
 				productCode:  platform.QDJVM,
 			},
-			want: runScenarioScoped,
+			want: runScenarioLocalChanges,
 		},
 	}
 	for _, tt := range tests {

platform/argflags.go

@@ -73,7 +73,7 @@ func ComputeFlags(cmd *cobra.Command, options *QodanaOptions) error {
 
 	flags.StringVar(&options.DiffStart, "diff-start", "", "Commit to start a diff run from. Only files changed between --diff-start and --diff-end will be analysed.")
 	flags.StringVar(&options.DiffEnd, "diff-end", "", "Commit to end a diff run on. Only files changed between --diff-start and --diff-end will be analysed.")
-	flags.BoolVar(&options.ForceDiffMode, "force-diff-analysis-mode", false, "Override the default run-scenario for diff runs to always use the restart-based approach")
+	flags.BoolVar(&options.ForceLocalChangesScript, "force-local-changes-script", false, "Override the default run-scenario for diff runs to always use the local-changes script")
 
 	flags.IntVar(&options.JvmDebugPort, "jvm-debug-port", -1, "Enable JVM remote debug under given port")
 
@@ -98,7 +98,7 @@ func ComputeFlags(cmd *cobra.Command, options *QodanaOptions) error {
 		cmd.MarkFlagsMutuallyExclusive("env", "ide")
 	}
 
-	cmd.MarkFlagsMutuallyExclusive("script", "force-diff-analysis-mode", "full-history")
+	cmd.MarkFlagsMutuallyExclusive("script", "force-local-changes-script", "full-history")
 	cmd.MarkFlagsMutuallyExclusive("commit", "script", "diff-start")
 	cmd.MarkFlagsMutuallyExclusive("profile-name", "profile-path")
 	cmd.MarkFlagsMutuallyExclusive("apply-fixes", "cleanup")
@@ -112,7 +112,7 @@ func ComputeFlags(cmd *cobra.Command, options *QodanaOptions) error {
 		return err
 	}
 	err = cmd.Flags().MarkHidden("jvm-debug-port")
-	err = cmd.Flags().MarkHidden("force-diff-analysis-mode")
+	err = cmd.Flags().MarkHidden("force-local-changes-script")
 	if err != nil {
 		return err
 	}

platform/options.go

@@ -57,7 +57,7 @@ type QodanaOptions struct {
 	Commit                    string
 	DiffStart                 string
 	DiffEnd                   string
-	ForceDiffMode             bool
+	ForceLocalChangesScript   bool
 	AnalysisId                string
 	Env                       []string
 	Volumes                   []string