Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popesku/add validation token #185

Merged

Conversation

KoT9R
Copy link

@KoT9R KoT9R commented Sep 6, 2023

Pull Request Details

Added validation of qodana clout token to avoid cases where the token is incorrect and the analysis is in progress.

Description

options. go: refactor code, move steps of getting token into functions LGTM

license. go: added new warning message if the token is not correct

qodana_cloud_client.go: HTTP client, which requests qodana cloud to validate the token

validation_token_test.go: some tests

Motivation and Context

These changes allow you to avoid situations, when you have a big project, in which analyzing takes a lot of time, and in the end, you get a message that the report can't be sent to the cloud, because it is not corrected 😠

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit messages are styled with gitmoji
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@KoT9R KoT9R force-pushed the popesku/add-validation-token branch from 147e336 to daac217 Compare September 7, 2023 07:17
@KoT9R KoT9R force-pushed the popesku/add-validation-token branch from daac217 to 064863d Compare September 7, 2023 07:31
@tiulpin tiulpin changed the base branch from main to token-validation September 7, 2023 10:57
@tiulpin tiulpin merged commit 349854e into JetBrains:token-validation Sep 7, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants