-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token validation #186
Merged
Merged
Token validation #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiulpin
force-pushed
the
token-validation
branch
from
September 8, 2023 13:27
afd08ac
to
489fc44
Compare
tiulpin
force-pushed
the
token-validation
branch
from
September 8, 2023 14:07
489fc44
to
8004935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Working together with @KoT9R.
Added validation of qodana clout token to avoid cases where the token is incorrect, and the analysis is in progress.
Description
options. go: refactor code, move steps of getting token into functions LGTM
license. go: added new warning message if the token is not correct
qodana_cloud_client.go: HTTP client, which requests qodana cloud to validate the token
validation_token_test.go: some tests
Motivation and Context
These changes allow you to avoid situations when you have a big project in which analyzing takes a lot of time, and in the end, you get a message that the report can't be sent to the cloud because it is not corrected 😠
Types of changes
Checklist