Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Deprecate stub-profile flag (QD-6638) #199

Closed
wants to merge 1 commit into from
Closed

🗑️ Deprecate stub-profile flag (QD-6638) #199

wants to merge 1 commit into from

Conversation

jckoenen
Copy link
Contributor

@jckoenen jckoenen commented Oct 4, 2023

Pull Request Details

Removes the --stub-profile flag from generated application args, remove default profile.xml argument too.

Description

The flag is considered legacy and is being removed from Qodana. If users still supply the flag, a notice is logged.

On a side note, it's my first time writing golang, so I'm happy for any pointers. :)

How Has This Been Tested

Ran qodana locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

It's a deprecation.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit messages are styled with gitmoji
  • My change requires a change to the documentation. When implemented on IDE side
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Removes the `--stub-profile` flag from generated IDE args, remove default `profile.xml` argument too.
@jckoenen
Copy link
Contributor Author

jckoenen commented Oct 6, 2023

Superseded by #200

@jckoenen jckoenen closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant