v2023.3 #223
Merged
v2023.3 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lost during migration from entrypoint
Refactor and Extract CI/CD-related code in 'core/container.go' and 'core/core_test.go' files. Test file modifications are extensive and mainly include renaming, method extraction, and cleanup to improve readability and organization of test conditions. The CI/CD code extraction made the 'PrepareContainerEnvSettings' method cleaner and more focused. Consequentially, the 'cmd/pull.go' file is updated to use the refactored method. Changes also include extracting the 'QODANA_*' environment variables to a separate function for better modularity. Revisions in the '.github/workflows/ci.yml' file includes replacing 'QODANA_TOKEN' with 'QODANA_LICENSE_ONLY_TOKEN' to reflect changes in token handling. Additionally, 'core/ide.go' and 'cmd/pull.go' have minor changes to reflect the decoupling of Qodana environment and CI/CD related settings.
By default in container we will disable .NET Framework completely.
- in qodana we don't open project via activities, flag must be enabled when we would want to do that - see in intellij f036cf057bed40c54545826909e27f090667af06 com.jetbrains.python.sdk.PythonSdkUpdater#dropUpdaterInHeadless
Closed
tiulpin
force-pushed
the
2023.3
branch
3 times, most recently
from
b2505dd to
d4982af
Compare
Qodana for GoIt seems all right 👌 No new problems were found according to the checks applied @@ Code coverage @@
+ 59% total lines covered
3869 lines analyzed, 2317 lines covered
! 59% fresh lines covered
436 lines analyzed, 261 lines covered
# Calculated according to the filters of your coverage tool💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
tiulpin
force-pushed
the
2023.3
branch
8 times, most recently
from
2303217 to
c538822
Compare
tiulpin
force-pushed
the
2023.3
branch
3 times, most recently
from
5706a3b to
0b471b5
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
11 tasks
hybloid
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.