Avafanasev/qd 10360 qd 10419 #484
Open
+45
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for Go1 new problem were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
core/ide.go:58
- Ensure that calling writeProperties before getIdeRunCommand does not introduce any side effects that affect the command generation.
writeProperties(opts)
hybloid
approved these changes
Dec 3, 2024
| @@ -82,19 +74,51 @@ func getPropertiesMap( | |||
| return properties | |||
| } | |||
|
|
|||
| // GetProperties writes key=value `props` to file `f` having later key occurrence win | |||
| func GetProperties(opts *QodanaOptions, yamlProps map[string]string, dotNetOptions platform.DotNet, plugins []string) []string { | |||
| // Common part for installPlugins and qodana executuion | |||
There was a problem hiding this comment.
I would rather follow advice from linter here and adjust the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Related Issue
Motivation and Context
How Has This Been Tested
Types of changes
Checklist