Skip to content

Commit

Permalink
Add skia_use_fonthost_mac=true and change version to 126-1d69d9b-2
Browse files Browse the repository at this point in the history
  • Loading branch information
eymar committed Aug 5, 2024
1 parent 615c673 commit 7079559
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
default: 'false'

env:
version: m126-1d69d9b-1
version: m126-1d69d9b-2

jobs:
macos:
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ Prebuilt binaries can be found [in releases](https://github.com/JetBrains/skia-p
## Building locally

```sh
python3 script/checkout.py --version m126-1d69d9b-1
python3 script/checkout.py --version m126-1d69d9b-2
python3 script/build.py
python3 script/archive.py --version m126-1d69d9b-1
python3 script/archive.py --version m126-1d69d9b-2
```

To build a debug build:

```sh
python3 script/checkout.py --version m126-1d69d9b-1
python3 script/checkout.py --version m126-1d69d9b-2
python3 script/build.py --build-type Debug
python3 script/archive.py --version m126-1d69d9b-1 --build-type Debug
python3 script/archive.py --version m126-1d69d9b-2 --build-type Debug
```
5 changes: 4 additions & 1 deletion script/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def main():
isTvos = 'tvos' == target or 'tvosSim' == target
isIosSim = 'iosSim' == target
isTvosSim = 'tvosSim' == target
isMacos = 'macos' == target

if build_type == 'Debug':
args = ['is_debug=true']
Expand All @@ -39,7 +40,9 @@ def main():
'skia_enable_skottie=true'
]

if 'macos' == target or isIos or isTvos:
if isMacos or isIos or isTvos:
if isMacos:
args += ['skia_use_fonthost_mac=true']
args += ['extra_cflags_cc=["-frtti"]']
args += ['skia_use_metal=true']
if isIos:
Expand Down

0 comments on commit 7079559

Please sign in to comment.