Merge pull request #35 from JetBrains/wa_ios_min_target

workaround ios_min_target
JetBrains · Feb 28, 2023 · 84d02b2 · 84d02b2
2 parents 5b54d9a + e0429bc
commit 84d02b2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -13,7 +13,7 @@ on:
         default: 'false'
 
 env:
-  version: m110-ad42464
+  version: m110-ad42464-1
 
 jobs:
   macos:

diff --git a/README.md b/README.md
@@ -15,15 +15,15 @@ Prebuilt binaries can be found [in releases](https://github.com/JetBrains/skia-p
 ## Building locally
 
 ```sh
-python3 script/checkout.py --version m110-ad42464
+python3 script/checkout.py --version m110-ad42464-1
 python3 script/build.py
-python3 script/archive.py --version m110-ad42464
+python3 script/archive.py --version m110-ad42464-1
 ```
 
 To build a debug build:
 
 ```sh
-python3 script/checkout.py --version m110-ad42464
+python3 script/checkout.py --version m110-ad42464-1
 python3 script/build.py --build-type Debug
-python3 script/archive.py --version m110-ad42464 --build-type Debug
+python3 script/archive.py --version m110-ad42464-1 --build-type Debug
 ```
diff --git a/script/build.py b/script/build.py
@@ -44,9 +44,10 @@ def main():
     ]
     if isIos:
       args += ['target_os="ios"']
-      args += ['ios_min_target="11.0"']
       if isIosSim:
         args += ['ios_use_simulator=true']
+      else:
+        args += ['ios_min_target="11.0"']
     else:
       if 'arm64' == machine:
         args += ['extra_cflags=["-stdlib=libc++"]']