Update skia version to m122 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's different m122 than here #45
Added 2 small changes to fix the compilation:
JetBrains/skia@3a00e26#diff-2d9953294215dc5f2d5ed54255cac3cf1bf4fe7e38f5b0070a87ed910f1cb59dR6
string: JetBrains/skia@1ac04efUpdated windows agent from 2019 to 2022 (Didn't work with 2019. It seems a newer python version fixed the problem).
Updated ndk version to 25 (previous version 21 didn't compile android debug build)
Currently the commit is JetBrains/skia@6726cd3 in
https://github.com/JetBrains/skia/commits/skiko/