Replace binds for methods with lambda methods #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per "Replace any binds for methods with lambda methods" in #13
Rather than use
.bind()
for class methods before calling them, we can actually use lambda properties as class methods that automatically bind tothis
(this way, the caller doesn't need to remember to callbind()
before calling the function).I also see that we have functions called
bind_this
that call.bind
on all functions of an object and it's prototype chain, both in the main greeter code and some of the themes, but I can't find references to it anywhere? As far as i can tell, all these functions can be deleted, but didn't want to do that until you've confirmed @JezerM that they are indeed not used in some weird reflective way etc...