Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace binds for methods with lambda methods #19

Closed
wants to merge 2 commits into from

Conversation

s0
Copy link
Contributor

@s0 s0 commented Feb 12, 2022

As per "Replace any binds for methods with lambda methods" in #13

Rather than use .bind() for class methods before calling them, we can actually use lambda properties as class methods that automatically bind to this (this way, the caller doesn't need to remember to call bind() before calling the function).

I also see that we have functions called bind_this that call .bind on all functions of an object and it's prototype chain, both in the main greeter code and some of the themes, but I can't find references to it anywhere? As far as i can tell, all these functions can be deleted, but didn't want to do that until you've confirmed @JezerM that they are indeed not used in some weird reflective way etc...

@JezerM
Copy link
Owner

JezerM commented Feb 17, 2022

I don't think this solution is either worthy or necessary, as this "does a lot" just to remove two bind functions. Also, I don't like how it looks xd

About theme_utils.bind_this, surely almost no theme needs it, but lightdm-webkit2-theme-glorious does use it. I could set it as a deprecated method and remove it on future versions~

@s0 s0 closed this Apr 28, 2022
JezerM added a commit that referenced this pull request Dec 23, 2022
Patch Xgreeter file to run nody-greeter as non-sandboxed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants