Migrate default themes to TypeScript #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JezerM
commented
Apr 15, 2022
There was a problem hiding this comment.
I think everything is okay. The current behavior is practically the same as before, with some improvements, and should be easier to maintain and navigate through.
Also, I was thinking about using a bundler, like Webpack or Vite.js, which could help to remove the _vendors packages and use the npm ones, but this could difficult the build process. Maybe, this would be implemented in a future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13
Changes
transitionCSS rule for all elements in HTML for Dracula, which improves performance.npm run build:themesnpm run lint:themes, and fix withnpm run lint:themes:fixnpm run prettier:themes, and fix withnpm run prettier:themes:fixnpm run buildnow builds both themes and nody-greeter.