Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-monitor support #41

Merged
merged 22 commits into from
Jun 9, 2022
Merged

Multi-monitor support #41

merged 22 commits into from
Jun 9, 2022

Conversation

JezerM
Copy link
Owner

@JezerM JezerM commented Apr 19, 2022

Based on nody-greeter Multi-monitor support.

Changes

  • Refactor browser.py:
    • Added a BrowserWindow class to abstract windows in a similar way of what Electron.js does.
    • Make use of Application.screens() to create a BrowserWindow for each screen/display
    • Devtools, menubar, qdock, and keybindings are now managed by BrowserWindow instead of Browser.
  • Bridge objects are connected to each window.
  • Added index.yml support (from Nody Greeter) to load theme config and set both primary and secondary HTML to each window.
  • Now, the code should be easier to understand

TODO

  • Access to LightDM API from all windows
  • Implement index.yml's nody-greeter configuration loader
  • Implement cross window communication system
  • Make web-greeter and nody-greeter compatible in terms of multi-monitor support (would require nody-greeter changes)
  • Add secondary HTML files to gruvbox and dracula themes as nody-greeter currently offers.

@JezerM
Copy link
Owner Author

JezerM commented Jun 9, 2022

Finally, after a few long months of homework, I'm free to develop furthermore with this.

GreeterComm, a utility to ease communication between all windows, is finally implemented as greeter_comm in Javascript. This nomenclature change will be applied to nody-greeter soon.

Multi-monitor themes are not available yet.

@JezerM
Copy link
Owner Author

JezerM commented Jun 9, 2022

This should be done right now. It will be merged soon.

@JezerM JezerM merged commit 922b7f8 into master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant