Fix make uninstall #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"${DESTDIR_PREFIX}/web-greeter/" expands as "/usr/web-greeter"
* put /usr/share/web-greeter under `uninstall_all` because that's
where themes are
* put /usr/lib/web-greeter under `uninstall_preserve` based on the
comment: "Uninstall everything except themes and web-greeter.yml"
Removing lightdm-wrapper turned out to be a typo: `.` instead of `-` at
one point.
App icon removal missing.
|
LGTM, thanks! Sorry for the late response |
|
It's okay 😄 Thanks for merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, turns out I found some issues in the Makefile, and the fix seems perfect 😄
Please make sure for example that
/usr/lib/web-greeter/is removed as intended and in the right place.Plus added a small correction for
\ns being literal inmake uninstall_preserveoutput as follows:This PR should especially make it easier to switch between a manual build and building with AUR.