fix(Main): ChooseToggleActionButton disabled bug

Ji4n1ng · May 5, 2019 · fef4e87 · fef4e87
1 parent 3d7acaf
commit fef4e87
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/OpenInTerminal/PreferencesWindow/GeneralPreferencesViewController.swift b/OpenInTerminal/PreferencesWindow/GeneralPreferencesViewController.swift
@@ -62,6 +62,7 @@ class GeneralPreferencesViewController: PreferencesViewController {
         chooseToggleActionButton.removeAllItems()
         [quickToggleTerminalMenuItem, quickToggleEditorMenuItem,
          quickToggleCopyPathMenuItem].forEach {
+            $0.target = self
             chooseToggleActionButton.menu?.addItem($0)
         }
     }
@@ -145,7 +146,6 @@ class GeneralPreferencesViewController: PreferencesViewController {
         SMLoginItemSetEnabled(Constants.launcherAppIdentifier as CFString, isLaunch)
     }
 
-
     @IBAction func quickToggleButtonClicked(_ sender: NSButton) {
         let quickToggle: BoolType = quickToggleButton.state == .on ? ._true : ._false
         CoreManager.shared.quickToggle = quickToggle
@@ -156,16 +156,6 @@ class GeneralPreferencesViewController: PreferencesViewController {
         logw("Quick Toggle set to \(sender.state.rawValue)")
     }
 
-//    @IBAction func chooseToggleActionButtonClicked(_ sender: NSPopUpButton) {
-//        let itemTitles = sender.itemTitles
-//        let index = sender.indexOfSelectedItem
-//        let title = itemTitles[index]
-//
-//        if let quickToggleType = QuickToggleType(rawValue: title) {
-//            CoreManager.shared.quickToggleType = quickToggleType
-//        }
-//    }
-
     @IBAction func defaultTerminalButtonClicked(_ sender: NSPopUpButton) {
         let itemTitles = sender.itemTitles
         let index = sender.indexOfSelectedItem
@@ -194,17 +184,17 @@ class GeneralPreferencesViewController: PreferencesViewController {
         }
     }
 
-    @objc func quickToggleTerminalClicked() {
+    @objc func quickToggleTerminalClicked(_ sender: NSMenuItem) {
         CoreManager.shared.quickToggleType = .openWithDefaultTerminal
         chooseToggleActionButton.select(quickToggleTerminalMenuItem)
     }
 
-    @objc func quickToggleEditorClicked() {
+    @objc func quickToggleEditorClicked(_ sender: NSMenuItem) {
         CoreManager.shared.quickToggleType = .openWithDefaultEditor
         chooseToggleActionButton.select(quickToggleEditorMenuItem)
     }
 
-    @objc func quickToggleCopyPathClicked() {
+    @objc func quickToggleCopyPathClicked(_ sender: NSMenuItem) {
         CoreManager.shared.quickToggleType = .copyPathToClipboard
         chooseToggleActionButton.select(quickToggleCopyPathMenuItem)
     }