-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PnP update #64
PnP update #64
Conversation
@schornakj can you review? This is ready to merge but has a few changes that might overlap with #62 |
I'll rebase onto your changes after we merge. #62 adds a function that's similar (but uses different underlying Ceres functions) to the "full" covariance function you added here so you might be interested in taking a look and seeing which approach you prefer. |
…zation results for perturbed tests
@schornakj I addressed your comments in the latest commits. I ended up running the randomly initialized optimizations 30 times and setting expectations that the mean error + 3 standard deviations should be less than a (still somewhat arbitrary) threshold. I think this is at least a step in the right direction for setting reasonable expectations for unit tests with randomness |
That's reasonable. Looks good to me! |
Per investigation in #57, this PR provides a workaround for using Eigen objects without local paramterization. It also adds a function for calculating the "full" covariance matrix between two parameter blocks (i.e. variance with the parameter block itself and covariance with the other parameter block)