Add special check for ChromeOS's mountpoint #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much simpler fix/workaround for ChromeOS.
The issue on ChromeOS is that external USB disks are mounted into /mnt/external/DISKNAME in Linux (Crostini), while elf2uf2-rs only checks /mnt/chromeos and /mnt/external but not /mnt/external/RPI-RP2
Instead of having a manual switch as I had before, it's actually much easier to simply check for the /mnt/external/RPI-RP2 directory to exist: if it does, use that directory for uploading the UF2 file.
While the code does not check for the INFO_UF2.TXT file, it uses the hard-coded volume name instead.
Thus my other pull request Make elf2uf2-rs work on Crostini