This repository has been archived by the owner on Dec 29, 2024. It is now read-only.
Handle JSON parse error on multiple build stream data chunks #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where the streamed data to
docker.buildImage
is large (for instance in a large app with 100+ modules), a single message can be split among multiple chunks, in which caseJSON.parse(data)
will throw an error and the build will fail out.This change temporarily adds the contents of
data
into a variablecumulativeData
. IfJSON.parse(cumulativeData)
fails, it will just go on to the next chunk, add it tocumulativeData
and try again. If it succeeds, it will send the parsed data to the log and clearcumulativeData
until the next chunk.Also, just to be sure nothing hangs around,
cumulativeData
is cleared on botherror
andend
states of the stream.