Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zoom scroll #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peshkira
Copy link

When a user zooms in a page, and swipes to the end of it, then they cannot scroll to the next page.
This PR changes this by comparing the last known current X or Y Offset (depending on vertical swiping) and then shows the next/previous page. When this happens the zoom is reset, as it seems most apps with similar functionality, do this.

Unfortunately, I had to change the build.grade sdk versions, as Android Studio complained that the build tools version is too low.

Also I saw that there are some API Calls that require API 11, however the min is set to 8

updating to gradle 1.3
updating to 19.1.0 because Android Studion complains.
When the user scrolls to the end of a zoomed page and then swipes again,
the pdf view goes to the next page.
@uugan
Copy link

uugan commented Dec 14, 2015

Peshkira I think you should save also zoom. When you swipe zoom goes to default value.
Please merge these commits! PdfView doesn't swipe when zoomed in.

@peshkira
Copy link
Author

peshkira commented Jan 8, 2016

Thanks @uugan. I am not sure, if the zoom should remain when the page is changed. I took a look at a number of popular apps that render PDFs and they all seem to reset the zoom. It makes sense to me, because you immediately have an overview of the page and you can go through more pages faster (when they are not zoomed). Otherwise it can get confusing.

However, maybe we can make a setting of it and let the developer decide what happens.

@uugan
Copy link

uugan commented Jan 8, 2016

@peshkira well i tested some free pdf readers like MuPDF, Adobe Acrobat Reader. It depends on which way to swipe. If you swipe up/down then zoom is stored its value but when swipe right/left then zoom goes to default value.
P.S. 11 Pull requests no answer :(

@Shajeel-Afzal
Copy link

Hi, How can we add Zoom Functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants