Improve Application Docker Support #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 20, 2019 19:00
Modify the compose file so it’s even easier to build a custom version for you.
Utilize retrieving the configuration items from the process environment in node. This is a better fit with the docker ecosystem and allows endusers to just pull/configure the image as they are used to with docker.
|
Thanks for this, its probably a good idea to ship this project in Docker images now its stable. My main concern is how to package up the two images, ideally I'd like to use Docker Hub automated builds but AFAIK it only supports one image per repo. I'm not sure how good practise it is having multiple separate images using tags. Do you think its better to make two Docker images |
|
I guess it would make sense to have two images, so you can upgrade the mail component while keeping the app part running or vice versa. I am unfortunately not familiar with Docker Hub automated builds but if they only support one image per repo you might need to split up the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I further dockerized the application, so users should be able to just pull/configure the images as they are used to with docker. This required me changing a bit of the configuration code as well.
However, as I am not well-versed with node development, there may be better options.
I also took the liberty to rename the app labels, as user might want to go for copy and paste integration and already might have a docker container named "app"/"db" or "mail".
I hope this helps publishing some "official" images.
Cheers,
Jens