Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug msgs #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Martin-Zeithaml
Copy link
Contributor

@Martin-Zeithaml Martin-Zeithaml commented Sep 26, 2024

Problem

Some C functions has debug messages, which is fine. But:

  • Incorrect encoding makes it difficult to read
  • When fails as javascript call, it should respect configmgr trace level and some message format
  • Deleting these messages is the most simple solution

ChangeTag

zos.changeTag prints garbage when fails.

Without fix

��/��ʀ�/�%������ǀ���>?�����zos.changeTag()=-1
��/��ʀ�/�%������ǀ���>?�����zos.changeTag(null)=-1
��/��ʀ�/�%������ǀ���>?�����zos.changeTag(undefined)=-1
��/��ʀ�/�%������ǀ���>?�����zos.changeTag(-12)=-1
��/��ʀ�/�%������ǀ���>?�����zos.changeTag(0)=-1
��/��ʀ�/�%������ǀ���>?�����zos.changeTag(28)=-1
��/��ʀ�/�%������ǀ���>?�����zos.changeTag(./file, which does not exit)=-1
��/��ʀ�/�%������ǀ���>?�����zos.changeTag(./file, which does not exit,250000)=-1

With fix

zos.changeTag()=-1
zos.changeTag(null)=-1
zos.changeTag(undefined)=-1
zos.changeTag(-12)=-1
zos.changeTag(0)=-1
zos.changeTag(28)=-1
zos.changeTag(./file, which does not exit)=-1
zos.changeTag(./file, which does not exit,250000)=-1

ChangeStreamCCSID

zos.changeStreamCCSID prints garbage when fails.

Without fix

zos.changeStreamCCSID("")=0
zos.changeStreamCCSID("null")=0
zos.changeStreamCCSID("undefined")=0
zos.changeStreamCCSID("true")=0
zos.changeStreamCCSID("false")=0
���>���>/%����?ʊ��?>����|��>����/_����/>��/���������Ā��>���?>���/%%�����>�%��/�%������>?�����zos.changeStreamCCSID("-16")=-1
zos.changeStreamCCSID("0")=0
���>���>/%����?ʊ��?>����|��>����/_����/>��/���������Ā��>���?>���/%%�����>�%��/�%������>?�����zos.changeStreamCCSID("256")=-1
���>���>/%����?ʊ��?>����|��>����/_����/>��/���������Ā��>���?>���/%%�����>�%��/�%������>?�����zos.changeStreamCCSID("3.141592")=-1
���>���>/%����?ʊ��?>����|��>����/_����/>��/���������Ā��>���?>���/%%�����>�%��/�%������>?�����zos.changeStreamCCSID("999999999")=-1
zos.changeStreamCCSID("["banana","apple","kiwi"]")=0
zos.changeStreamCCSID("{"success":"guaranteed"}")=0

With fix

zos.changeStreamCCSID("")=0
zos.changeStreamCCSID("null")=0
zos.changeStreamCCSID("undefined")=0
zos.changeStreamCCSID("true")=0
zos.changeStreamCCSID("false")=0
zos.changeStreamCCSID("-16")=-1
zos.changeStreamCCSID("0")=0
zos.changeStreamCCSID("256")=-1
zos.changeStreamCCSID("3.141592")=-1
zos.changeStreamCCSID("999999999")=-1
zos.changeStreamCCSID("["banana","apple","kiwi"]")=0
zos.changeStreamCCSID("{"success":"guaranteed"}")=0

Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
@Martin-Zeithaml Martin-Zeithaml changed the title Remove debug msg Remove debug msgs Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant