Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARKNLP-907 Allows setting up ONNX configs through spark session #13979

Closed
wants to merge 3 commits into from
Closed

SPARKNLP-907 Allows setting up ONNX configs through spark session #13979

wants to merge 3 commits into from

Conversation

danilojsl
Copy link
Contributor

Description

This change allows users to define ONNX session configuration through spark session.

Motivation and Context

Flexibility for users when using ONNX models

How Has This Been Tested?

Screenshots (if appropriate):

  • Local Tests
  • Google Colab notebooks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added new-feature Introducing a new feature DON'T MERGE Do not merge this PR labels Sep 13, 2023
@danilojsl danilojsl closed this Sep 26, 2023
@danilojsl
Copy link
Contributor Author

Closed in favor of a cleaner implementation (check PR: #14009)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi Awaiting requested review from maziyarpanahi

Assignees
No one assigned
Labels
DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danilojsl