Update renovate pre-commit to use lts version of node #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Strunk <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around renovatebot/pre-commit-hooks#2460 by overriding the version of nodejs that is installed. Inspired by renovatebot/pre-commit-hooks#2460 (comment).
Root cause seems to be that pre-commit defaults to installing the latest version of node if (1) it's not already present or (2) it's running on Windows: https://github.com/pre-commit/pre-commit/blob/611195a088a29821961c5ddae2f4312f748f4a85/pre_commit/languages/node.py#L27-L36
So, when node 23 was released, the renovate hook broke.
Based on pre-commit/pre-commit#3340 and ekalinin/nodeenv#281, I'm just requesting LTS instead of locking to a specific version.