Add support for gpg2.1, ubuntu 18.04 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
might need to start agent as # gpg-agent --daemon --pinentry-program /usr/bin/pinentry-curses after GNUPGHOME env var is set
(e.g. don't check for custom kernels)
Add a cache directory. if the grub.cfg and publickey are the same, do not rebuild and resign grub.
We now log to syslog all operations. In addition to the --sign-all force-override, we now check, for each file, if: a) .sig is present b) .sig is reasonable size c) .sig is verifiable via gpg if not, force resign
it appears update-initramfs can be called w/ /boot/vmlinu...sig which causes a .sig.sig to appear. Remove if present
In a helper function we turned off exiting on error, then enabled it after calling an external utility. This had the behavior of forcing later calls in the script to immediately exit whenever a non-zero error code was returned by anything. Unfortunatly, we were testing the result of a helper function (`CheckSig`) by testing `$?`. If it was non-zero, we'd immediately exit the program, leading to a failure to actually generate signatures, and a failure to finish installation. Change the code to set the flags in the correct order.
fix: swap -e and +e in helper function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few minor changes were needed, gpg -k doesn't list the keyids, support for nvme disks, add sha256/sha512 modules to grub