Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Onboarding UI updates #2931

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Aug 13, 2024

Description

We now have a new sidebar for our Onboarding pages. We are now only handling 2 breakpoints for our Onboarding pages: sm and non-sm.

Screenshot 2024-08-13 at 11 55 42

Screenshot 2024-08-13 at 11 55 56

Testing

Note

The Feedback Button will be developed separately
The Colony Switcher UI will be completed separately

Colony Creation Flow

  1. Run this command on your terminal to create a colony creation URL:
node scripts/create-colony-url.js
  1. Open the URL it generates, it should take you to the Colony Creation flow
  2. Set your browser width to at least 768px
  3. Verify that the Sidebar matches the Figma designs
  4. Set the browser width to 767px
  5. Verify that the mobile view is still the same as it was
  6. Click the Colony Icon on the Sidebar
  7. Verify that the Colony Switcher appears and that you're still on the same page

Account Creation Flow

  1. Connect Dev Wallet 16
  2. On the Landing page, click "Create profile"
  3. Set your browser width to at least 768px
  4. Verify that the Sidebar matches the Figma designs
  5. Set the browser width to 767px
  6. Verify that the mobile view is still the same as it was
  7. Click the Colony Icon on the Sidebar
  8. Verify that the Colony Switcher appears and that you're still on the same page

Diffs

Changes 🏗

  • WizardSidebar is now just called Wizard
  • MobileWizardSidebar is now called MobileWizardHeader
  • Our PageLayout has been historically designed to switch between tablet and desktop. But it now has a enableMobileAndDesktopLayoutBreakpoints boolean prop which makes it switch between mobile and desktop views instead

Resolves #2889 & #2887

@rumzledz rumzledz self-assigned this Aug 13, 2024
@rumzledz rumzledz force-pushed the ui/2889-new-onboarding-ui branch 5 times, most recently from 067aef9 to 047206b Compare August 13, 2024 11:16
@rumzledz rumzledz marked this pull request as ready for review August 13, 2024 11:31
@rumzledz rumzledz requested review from a team as code owners August 13, 2024 11:31
@rumzledz rumzledz changed the title ui: onboarding UI updates UI: Onboarding UI updates Aug 13, 2024
@mmioana mmioana self-requested a review August 13, 2024 12:31
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool work on this one @rumzledz 🥇

I have tested both the Create colony with missing profile and Create colony with leela profile flows
Screenshot 2024-08-13 at 14 42 35
Screenshot 2024-08-13 at 14 42 45
Screenshot 2024-08-13 at 14 45 15
Opening the colony selector
Screenshot 2024-08-13 at 14 42 23
Screenshot 2024-08-13 at 14 42 03

Only a couple of design remarks and one naming comment 🫠

  1. When you complete the create profile/create colony flow, the bubble next to the Complete step is invisible
    Screenshot 2024-08-13 at 14 37 41

  2. There is no header padding if you go to http://localhost:9091/go/{COLONY_NAME_HERE}
    Screenshot 2024-08-13 at 14 50 01

topContent?: ReactNode;
header?: ReactNode;
mobileAndDesktopLayout?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this property into something like isSmPaddingEnabled or applySmPadding or isSmStylingEnabled if we want to be a bit more general? I feel mobileAndDesktopLayout doesn't convey enough information as in why to use it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @mmioana !

When you complete the create profile/create colony flow, the bubble next to the Complete step is invisible

I shall investigate and fix this, great spot! 👌

Can we rename this property into something like isSmPaddingEnabled or applySmPadding or isSmStylingEnabled if we want to be a bit more general? I feel mobileAndDesktopLayout doesn't convey enough information as in why to use it

Tbh none of those variable names also convey what I'm trying to achieve here hahaha 😂 variable names are so difficult! It's not really a matter of applying padding on sm. It's a matter of varying the breakpoints primarily between mobile and desktop because by default, we are varying between md and everything above md. Happy to hear another batch of variable name suggestions and from everyone as well!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no header padding if you go to http://localhost:9091/go/{COLONY_NAME_HERE}

As for this, I'll see if this is relevant to my PR. If it isn't I will open a separate issue 👌

@mmioana

Copy link
Contributor Author

@rumzledz rumzledz Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmioana I've given it a longer name now 😂 I dunno if you're okay with it but would like to get your thoughts tomorrow! Oh and I've fixed the bugs you raised, thanks for that 👌

topContent?: ReactNode;
header?: ReactNode;
// When set to true, the PageLayout will apply sm vs desktop styles. As opposed to md vs desktop styles.
restrictLayoutToMobileAndDesktopBreakpoints?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better than before @rumzledz 🥇 though I believe it's more an enablement than a restriction 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha all right all right let's meet halfway, I shall call it enable! 🙌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmioana pushed! 🚀 I hope the variable name is much better now 🤞

Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes @rumzledz 🙏

Can confirm the complete step bubble is now visible ✅
Screenshot 2024-08-14 at 11 04 56

However regarding the title padding, I noticed if you go below 767px as the screen width, the title is right below the header, but feel free to open another issue for this one
Screenshot 2024-08-14 at 11 07 13
Screenshot 2024-08-14 at 11 07 19

@rumzledz rumzledz force-pushed the ui/2889-new-onboarding-ui branch 2 times, most recently from bdd36c4 to fc8b2c6 Compare August 14, 2024 10:46
@rumzledz rumzledz requested a review from a team August 15, 2024 14:14
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! All looking good to me:

Screenshot 2024-08-22 at 09 17 29 Screenshot 2024-08-22 at 09 21 23

Mobile views are as expected:

Screenshot 2024-08-22 at 09 17 49 Screenshot 2024-08-22 at 09 21 34

All the code changes look sensible too.

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and sensible changes. The refactored components seem less complex and convoluted. Nicely done.

Screenshot from 2024-08-22 17-34-44
Screenshot from 2024-08-22 17-35-07
Screenshot from 2024-08-22 17-35-32
Screenshot from 2024-08-22 17-36-25
Screenshot from 2024-08-22 17-36-45
Screenshot from 2024-08-22 17-37-06
Screenshot from 2024-08-22 17-37-22
Screenshot from 2024-08-22 17-38-08

@rumzledz rumzledz merged commit ec86191 into ui/new-navigation-ui Aug 22, 2024
3 of 5 checks passed
@rumzledz rumzledz deleted the ui/2889-new-onboarding-ui branch August 22, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants