Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update translations for Multi-sig transactions #2951

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: update translations for Multi-sig transactions #2951

merged 1 commit into from
Aug 20, 2024

Conversation

Nortsova
Copy link
Contributor

@Nortsova Nortsova commented Aug 14, 2024 •
edited
Loading

Description

Before After
image image
image image

Testing

Before start testing please set this to .env file:
VITE_DEBUG=false

  • Step 1. Install MultiSig extension with 2 threshold
  • Step 2. Give MultiSig permissions to leela and amy
  • Step 3. Login as amy from incognito
  • Step 4. Create MultiSig motion
  • Step 5. Approve MultiSig motion as amy
  • Step 6. Create MultiSig motion
  • Step 7. Reject MultiSig motion
  • Step 8. Check UserHub transaction tab
  • Step 9. All translations should be present
image image

Resolves #2916

@Nortsova Nortsova self-assigned this Aug 14, 2024
@Nortsova Nortsova requested review from a team as code owners August 14, 2024 21:19
@CLAassistant
Copy link

CLAassistant commented Aug 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Nortsova Nortsova linked an issue Aug 16, 2024 that may be closed by this pull request
[Multi-sig] bug: missing translations strings #2916
Closed
rumzledz
rumzledz approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@rumzledz rumzledz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @Nortsova ✨ Can confirm that I can see the following copies:

  • Finalize motion
  • Vote on MultiSig
  • Cancel MultiSig
  • Set MultiSig Thresholds
  • Expenditure Payment
    2951

@bassgeta bassgeta force-pushed the feat/multi-sig branch 2 times, most recently from 3e0eac8 to a7e7535 Compare August 19, 2024 11:03
@Nortsova Nortsova force-pushed the fix/2916-transactions-translations branch from 720d8e0 to 3e7c544 Compare August 19, 2024 13:35
bassgeta
bassgeta approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👌
image
image
Let's gooo 🚢

davecreaser
davecreaser approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@davecreaser davecreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @Nortsova, translations are all there!

Screenshot 2024-08-20 at 13 59 28

@Nortsova Nortsova merged commit 782993c into feat/multi-sig Aug 20, 2024
2 of 5 checks passed
@Nortsova Nortsova deleted the fix/2916-transactions-translations branch August 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassgeta bassgeta bassgeta approved these changes

@davecreaser davecreaser davecreaser approved these changes

@rumzledz rumzledz rumzledz approved these changes

Assignees

@Nortsova Nortsova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Multi-sig] bug: missing translations strings
5 participants
@Nortsova @CLAassistant @bassgeta @davecreaser @rumzledz