-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Conditionally show the KYC Card in the Crypto-to-Fiat tab #2956
Fix: Conditionally show the KYC Card in the Crypto-to-Fiat tab #2956
Conversation
4a88ebd
to
8db6ecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rumzledz , thanks for this nice fix! It works great! ✨
I can confirm that the loading state is present:
I can also confirm that I can see the KYC card, and the form is disabled:
I also need to create a liquidation address in order to make the KYC card disappear.
After I filled in the bank details, the KYC card disappeared from the UserHub, and the form became enabled:
This is probably not related to current PR, but it is something that I found quite important:
Note 1: There was a feature to open the verification modal by clicking "Complete verification," but it seems this functionality was removed. I'm not sure if it should be re-implemented now (from step 5 to 6).
Note 2: Sometimes, on submit, there is an error in the terminal, but nothing happens in the UI.
As a result, the user doesn't understand why the form is not being submitted. In the example provided, an API key is missing, but it could be any API error, and the user would never know what's going on:
Note 3: The "Update details" link should redirect to the Crypto-to-Fiat tab, but instead, it redirects to http://localhost:9091/account/profile
Thanks for reviewing this @Nortsova !
I double checked the original implementation of this button after our call earlier and I can confirm that on
This is worth investigating separately as this is also on the
This is current behaviour so I left it as it is since there's no mention of it in the issue. But I will speak to product to confirm and will amend it if necessary since it will be a very tiny change 😄 |
…ere is no liquidation address
8db6ecf
to
898e601
Compare
I've just pushed a fix for your point no. 3 regarding the "Update details" button @Nortsova and I had to rebase as well 👀 But yeah, as for your points 1 & 2, it would be better if we dealt with those separately 😄 Can I get a re-review when you're free? Cheers! |
Another update for you @Nortsova 😂 We won't be required to show any modals when the user lands on the Crypto-to-fiat page after clicking the Complete verification button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rumzledz for considering all my comments! I checked it again and everything works as expected! ✨ Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smashing work @rumzledz 💪
Loading state is looking great:
The banner shows when either KYC has not been completed or liquidation address is missing:
Screen.Recording.2024-08-20.at.21.49.07.mov
Once there is a liquidation address, the banner disappears:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
If the KYC status is not approved or if there is no liquidation address.
Testing
Important
In the
bridgeXYZMutation/src/index.ts
file, make sure you update theapiKey
with our sandbox api key.Connect a Dev Wallet that hasn't done a KYC check yet.
Resolves #2953