Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant scripts #1267

Merged
merged 9 commits into from
Jul 15, 2024
Merged

Remove redundant scripts #1267

merged 9 commits into from
Jul 15, 2024

Conversation

kronosapiens
Copy link
Member

@kronosapiens kronosapiens commented Jun 17, 2024 •
edited
Loading

Big clean-up of the codebase. This PR:

  • Deletes the entire migrations/ directory
  • Deletes a handful of unused scripts from the scripts/ directory
  • Deletes the task-related test files and scripts
  • Consolidates all test files into the tests/ directory
  • Consolidates the .solcover config files into the .solcover/ directory
  • Reorganizes package.json and .circleci/config.yml

@kronosapiens kronosapiens changed the base branch from develop to maint/hardhat20 June 17, 2024 15:00
@kronosapiens kronosapiens force-pushed the maint/delete-scripts branch 2 times, most recently from d742f87 to 8880e4c Compare June 17, 2024 17:40
@kronosapiens kronosapiens force-pushed the maint/delete-scripts branch 6 times, most recently from 7f5cffd to eb952c3 Compare June 18, 2024 16:46
Base automatically changed from maint/hardhat20 to develop July 1, 2024 10:31
@kronosapiens kronosapiens force-pushed the maint/delete-scripts branch from 27a47d1 to db513a4 Compare July 1, 2024 17:19
@area
Copy link
Member

area commented Jul 8, 2024

As discussed on a call, need to check that we're not nixing anything that the CDApp dev environment uses.

@kronosapiens
Copy link
Member Author

@area I've checked the deleted scripts and none of them show up in the CDapp repo

@area area force-pushed the maint/delete-scripts branch from db513a4 to f1ca52f Compare July 12, 2024 16:08
@kronosapiens kronosapiens force-pushed the maint/delete-scripts branch from f1ca52f to e559f95 Compare July 13, 2024 15:54
@area
Copy link
Member

area commented Jul 15, 2024

(Skipped) tests removed here can be pulled back in #717 if/when that is required.

@area area merged commit 2277ca6 into develop Jul 15, 2024
2 checks passed
@area area deleted the maint/delete-scripts branch July 15, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@area area area approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kronosapiens @area