Fix incorrect choice of accidentals on notes with same midi pitches on capx file import. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KartikShrivastava mind to check the mtest failures? |
|
Sure @Jojo-Schmitz, I'll check it out, but will take some time as my musescore setup isn't in-place. |
|
Esp. test7, the other 2 are apparently due to your fix and apparently correct, so I'll adjust the 2 ref files. |
Jojo-Schmitz
force-pushed
the
3.x-fixing-flat-to-sharp-upgrades
branch
from
fefecdf to
94fe22a
Compare
Jojo-Schmitz
force-pushed
the
3.x-fixing-flat-to-sharp-upgrades
branch
from
94fe22a to
e023b9d
Compare
|
@KartikShrivastava any progress? |
|
Hey @Jojo-Schmitz, sorry but I'm not working on this issue actively anymore. |
Jojo-Schmitz
force-pushed
the
3.x-fixing-flat-to-sharp-upgrades
branch
from
e023b9d to
2ca8276
Compare
Jojo-Schmitz
force-pushed
the
3.x-fixing-flat-to-sharp-upgrades
branch
from
2ca8276 to
5f0b21c
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
3 times, most recently
from
9164f41 to
abc8ede
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
bf247bf to
922a518
Compare
…n capx file import. (Back)port of musescore#6032
Jojo-Schmitz
force-pushed
the
3.x-fixing-flat-to-sharp-upgrades
branch
from
5f0b21c to
bf0b836
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
9326c7c to
88927e8
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
20 times, most recently
from
e03471a to
a4d9423
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
3 times, most recently
from
056b1c3 to
176e209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Back)port of musescore#6032 resp. musescore#20288, , plus adjusting 2 unit tests (both for test 4), which actually prove the fix right.
Resolves: https://musescore.org/en/node/304625 issue (b) (issue a) seems fixed in MusicXML import since long, but still exists in Capella import)