Fix GH#23119: Ensure TextLineBase properties are written for hairpins #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
3.x-cresc_gap_saving
branch
from
99a8442 to
c71d801
Compare
|
The failing mtest indicates a problem, seems above is the default on import, because it is a vocal staff. It gets imported correctly, with the hairpin above staff, but looses that when saving as mscx/mscz |
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
bf247bf to
922a518
Compare
Jojo-Schmitz
force-pushed
the
3.x-cresc_gap_saving
branch
4 times, most recently
from
3b689e6 to
468af2d
Compare
Jojo-Schmitz
commented
Dec 28, 2024
Jojo-Schmitz
commented
Dec 28, 2024
Jojo-Schmitz
force-pushed
the
3.x-cresc_gap_saving
branch
from
468af2d to
04f6beb
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
9326c7c to
88927e8
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
14 times, most recently
from
548bd53 to
46b8941
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
6 times, most recently
from
e03471a to
a4d9423
Compare
Jojo-Schmitz
force-pushed
the
3.x-cresc_gap_saving
branch
2 times, most recently
from
dfb67f2 to
b2a5a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of musescore#23125
Resolves: musescore#23119