Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Regression from #605 and also allow for [prev measure/system] in… #666

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

worldwideweary
Copy link

@worldwideweary worldwideweary commented Oct 1, 2024

… note-entry even when input state has no ChordRest

Resolves: #604 regression and enabling previous measure/previous system when input track doesn't contain a correspondent chordrest

That should do it. Unfortunately that means your "up-port" (is that the word?) would also need to be updated

Verification:

  1. Traversal through grace notes is verified:
1.webm
  1. Reason for issue is verified:
2.webm
  1. Update: allow previous measure and previous system (switches to voice one, but initially wasn't working at all when in that input state of not having any existing chordrest in 3.6.2 etc):
3.webm

…ystem] in note-entry even when input state has no ChordRest
@worldwideweary worldwideweary force-pushed the 3.x-Fix605AndFixPrevMeasureSystem branch from e0c1b4f to 4ce3d14 Compare October 1, 2024 20:58
Jojo-Schmitz pushed a commit that referenced this pull request Oct 2, 2024
… even when input state has no ChordRest

Port of #666
Jojo-Schmitz pushed a commit that referenced this pull request Oct 2, 2024
… even when input state has no ChordRest

Port of #666
Jojo-Schmitz pushed a commit that referenced this pull request Oct 2, 2024
… even when input state has no ChordRest

Port of #666
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x branch 2 times, most recently from bf247bf to 922a518 Compare December 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Note-entry - move to previous chord
1 participant