Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH#718: Don't cut time from main chord when grace note is set not to play #719

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Fix GH#718: Don't cut time from main chord when grace note is set not to play #719

wants to merge 1 commit into from

Conversation

Jojo-Schmitz
Copy link
Owner

Resolves: #718

@Jojo-Schmitz
Copy link
Owner Author

Jojo-Schmitz commented Dec 8, 2024 •
edited
Loading

That mtest failure seems to even prove the correctness of this fix.

The question is why doesn't Mu4 have this issue?

Also I wonder whether grace notes after need the same treatment.

@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x branch 2 times, most recently from bf247bf to 922a518 Compare December 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grace notes play even if they are "ticked off" to NOT play.
1 participant
@Jojo-Schmitz