Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH#698: Mac build doesn't start due to missing fonts #739

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Jojo-Schmitz
Copy link
Owner

@Jojo-Schmitz Jojo-Schmitz commented Dec 26, 2024

Resolves: #698

@cbjeukendrup
Copy link

When building without xcpretty, the full output from Xcode is shown, which contains:

PhaseScriptExecution Generate\ mscore/qrc_musescorefonts-Mac.cpp /Users/casper/Desktop/MuseScore/MuseScore3/build.release/build/mscoreapp.build/Release/Script-EE00D719849C0D18CCA55A77.sh (in target 'mscoreapp' from project 'mscore')
    cd /Users/casper/Desktop/MuseScore/MuseScore3
    /bin/sh -c /Users/casper/Desktop/MuseScore/MuseScore3/build.release/build/mscoreapp.build/Release/Script-EE00D719849C0D18CCA55A77.sh
RCC: Error in '/Users/casper/Desktop/MuseScore/MuseScore3/mscore/musescorefonts-Mac.qrc': Cannot find file '../fonts/finalbroadway/FinaleBroadway.otf'
Command PhaseScriptExecution failed with a nonzero exit code

<file alias="fonts/musejazz/MuseJazz.otf">../fonts/musejazz/MuseJazz.otf</file>
<file alias="fonts/petaluma/Petaluma.otf">../fonts/petaluma/Petaluma.otf</file>
<file alias="fonts/finalemaestro/FinaleMaestro.otf">../fonts/finalemaestro/FinaleMaestro.otf</file>
<file alias="fonts/finalebroadway/FinaleBroadway.otf">../fonts/finalbroadway/FinaleBroadway.otf</file>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the problem:

Suggested change
<file alias="fonts/finalebroadway/FinaleBroadway.otf">../fonts/finalbroadway/FinaleBroadway.otf</file>
<file alias="fonts/finalebroadway/FinaleBroadway.otf">../fonts/finalebroadway/FinaleBroadway.otf</file>

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhhh, what a stupid typo. Thanks for pointing it out ;-)

@cbjeukendrup
Copy link

By the way, to disable xcpretty on CI, go to Makefile.osx, and under ci, replace

    $(FORMATTER_START) xcodebuild -project ${XCODEPROJ} -configuration Release -target install $(FORMATTER_END);

with

    xcodebuild -project ${XCODEPROJ} -configuration Release -target install;

@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x-fix-finale-fonts-mac branch from 165c56c to a1c6391 Compare December 26, 2024 16:40
@Jojo-Schmitz Jojo-Schmitz changed the title Fix GH#738: Mac build doesn't start due to missing fonts Fix GH#698: Mac build doesn't start due to missing fonts Dec 26, 2024
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x-fix-finale-fonts-mac branch from a1c6391 to 282e918 Compare December 26, 2024 16:47
@Jojo-Schmitz Jojo-Schmitz force-pushed the 3.x-fix-finale-fonts-mac branch from 282e918 to 6657168 Compare December 26, 2024 17:36
@Jojo-Schmitz Jojo-Schmitz merged commit abb9252 into 3.x Dec 27, 2024
7 checks passed
@Jojo-Schmitz Jojo-Schmitz deleted the 3.x-fix-finale-fonts-mac branch December 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac build doesn't start
2 participants