Allow reversal of hook flags within Inspector: Chord #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldwideweary
force-pushed
the
3.7-AllowFlaghookReversal
branch
from
4a95ef1 to
9479993
Compare
Jojo-Schmitz
pushed a commit
that referenced
this pull request
Dec 29, 2024
Jojo-Schmitz
pushed a commit
that referenced
this pull request
Dec 29, 2024
|
I've tried to port it to Mu4, see musescore#25938, doesn't (yet) work though |
libmscore/property.cpp
Outdated
| @@ -78,6 +78,7 @@ static constexpr PropertyMetaData propertyList[] = { | |||
| { Pid::DIRECTION, false, "direction", P_TYPE::DIRECTION, DUMMY_QT_TRANSLATE_NOOP("propertyName", "direction") }, | |||
| { Pid::STEM_DIRECTION, false, "StemDirection", P_TYPE::DIRECTION, DUMMY_QT_TRANSLATE_NOOP("propertyName", "stem direction") }, | |||
| { Pid::NO_STEM, false, "noStem", P_TYPE::INT, DUMMY_QT_TRANSLATE_NOOP("propertyName", "no stem") }, | |||
| { Pid::HOOK_REVERSED, false, "hookReverse", P_TYPE::BOOL, DUMMY_QT_TRANSLATE_NOOP("propertyName", "reverse hook") }, | |||
There was a problem hiding this comment.
Probably better "hookReversed" or even "reversedHook" (requires changes elsewhere too) and "reversed hook"
|
Please add HOOK_REVERSED to ...mscore/plugin/api/elements.h too |
worldwideweary
force-pushed
the
3.7-AllowFlaghookReversal
branch
from
9479993 to
4bfd2ea
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
9326c7c to
88927e8
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
16 times, most recently
from
d7bdf01 to
1c178b8
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
4 times, most recently
from
e03471a to
a4d9423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/109706
Provides chord inspector checkbox to reverse hooks.
Didn't "hand-roll" the .ui changes but used Qt Creator so there may be some extra changes in there not absolutely necessary.
To test:
Kind of a gimmick, but so long as it doesn't hurt anything I suppose it might fulfill little niche use cases for some people.
Testing appreciated