Support for albums #79
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
master-to-3.x
branch
from
e11375e to
2215182
Compare
Jojo-Schmitz
force-pushed
the
master-to-3.x
branch
from
2215182 to
c752dd4
Compare
Jojo-Schmitz
force-pushed
the
master-to-3.x
branch
12 times, most recently
from
eecf045 to
d9c22dd
Compare
Jojo-Schmitz
force-pushed
the
master-to-3.x
branch
5 times, most recently
from
5e20b62 to
8f1e5c8
Compare
Jojo-Schmitz
force-pushed
the
master-to-3.x
branch
4 times, most recently
from
1155017 to
e126f11
Compare
Jojo-Schmitz
force-pushed
the
master-to-3.x
branch
7 times, most recently
from
64b3e60 to
aa9ba2e
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
3 times, most recently
from
9164f41 to
abc8ede
Compare
lyrra
force-pushed
the
albums3x
branch
2 times, most recently
from
fc5859c to
0e01f5e
Compare
| <string notr="true"/> | ||
| </property> | ||
| <property name="icon"> | ||
| <iconset resource="../../../../../../../tmp/QtCreator-FLYAKj/qtc-cmake-rKuWjOTJ/mscore/musescore_qmlcache.qrc"> |
| <string notr="true"/> | ||
| </property> | ||
| <property name="icon"> | ||
| <iconset resource="../../../../../../../tmp/QtCreator-FLYAKj/qtc-cmake-rKuWjOTJ/mscore/musescore_qmlcache.qrc"> |
|
The mtest reveal that these settings are (expected to be) <albumFrontTitleFontSize>10</albumFrontTitleFontSize>
<albumFrontComposerFontSize>10</albumFrontComposerFontSize>
<albumFrontLyricistFontSize>10</albumFrontLyricistFontSize>
<albumContentsTitleFontSize>10</albumContentsTitleFontSize>
<albumContentsTextFontSize>10</albumContentsTextFontSize>in the mtest scores. |
|
Mind to rebase and fix the merge conflicts? |
fixed currentScoreView updated correctly when switching between excerpts fixed crash on close album possible fix-workaround for session restore related crashes fix paint crash fix albummanagerdialog with no album loaded fixed albummanager window calls hide event when changing workspace drawFrontCover album title loaded modified PR musescore#6352 contents pages fixed crash when adding scores with different instrumentation on new album + playback fix read + collect_artifacts enable albumBreaks test default pause and mass change pause fixed problems related to restore session? (finally?) codestyle use albumScores() instead of x->score tests for legacy albums simplified and improved playback control fixed seq crash fixed restore session export parts at last good playback!!! fixed crashes related to deleted Album pages codestyle cleanup + small things fix build failure + codestyle forgot this file fixed mtests fixed mtest failure readme more cleanup and shorter mtest-scores forgot this again correct undo fixed various issues updateContents when disabling, crash fixes, drawFrontCover in .msca disabled Album Manager playback updated tests crash fixes fixed warning + less doLayout calls fixed parts editing + shadownote for parts comments codestyle rename and comments a few got left behind codestyle rename, delete old code, simplify codestyle a bunch of contents and renames forgot a couple of things updated text and readme changed how scores are deleted and forgot this fix crash by resetting tempScoreTabindex when closing an album another small fix fix crash when drag&drop with disabled movements, added support for enabling/disabling for parts, various other improvements readme removed text fixed editing parts and updating the view when editing them parts scoreview constraints final touches readme codestyle fix travis failure FIRST COMMIT AFTER GOOGLE SUMMER OF CODE:\ Added tabstops and cleaned ui file, again text styles for front cover and contents wip text styles for front cover and contents fixed rebase removed unused variable codestyle fixed build failure preferences
not sure if these changes to the reference-scores are valid, or if the albums-changes are wrongly causing them.
(squash) with patch: * albums: mtest musicxml default album-font-sizes
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
bf247bf to
922a518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, TBD before PR:
Current bugs (to be fixed):
crash if exiting(seems not related to this PR)(squashed all of Sergios - Anestis Kefalidis patches (from musescore#6145), and then rebased onto 3.x)
(it compiles almost on mingw, (get undefined reference to `__stack_chk_fail', something with -fstack-protector))Compiles in a clean build.
fixed currentScoreView updated correctly when switching between excerpts
fixed crash on close album
possible fix-workaround for session restore related crashes
fix paint crash
fix albummanagerdialog with no album loaded
fixed albummanager window calls hide event when changing workspace
drawFrontCover
album title loaded
modified PR musescore#6352
contents pages
fixed crash when adding scores with different instrumentation on new album + playback fix
read + collect_artifacts
enable albumBreaks test
default pause and mass change pause
fixed problems related to restore session? (finally?)
codestyle
use albumScores() instead of x->score
tests for legacy albums
simplified and improved playback control
fixed seq crash
fixed restore session
export parts
at last good playback!!!
fixed crashes related to deleted Album pages
codestyle
cleanup + small things
fix build failure + codestyle
forgot this file
fixed mtests
fixed mtest failure
readme
more cleanup and shorter mtest-scores
forgot this again
correct undo
fixed various issues
updateContents when disabling, crash fixes, drawFrontCover in .msca
disabled Album Manager playback
updated tests
crash fixes
fixed warning + less doLayout calls
fixed parts editing + shadownote for parts
comments
codestyle
rename and comments
a few got left behind
codestyle
rename, delete old code, simplify
codestyle
a bunch of contents and renames
forgot a couple of things
updated text and readme
changed how scores are deleted and forgot this
fix crash by resetting tempScoreTabindex when closing an album
another small fix
fix crash when drag&drop with disabled movements, added support for enabling/disabling for parts, various other improvements
readme
removed text
fixed editing parts and updating the view when editing them
parts scoreview constraints
final touches
readme
codestyle
fix travis failure
FIRST COMMIT AFTER GOOGLE SUMMER OF CODE:
Added tabstops and cleaned ui file, again
text styles for front cover and contents wip
text styles for front cover and contents
fixed rebase
removed unused variable
codestyle
fixed build failure
preferences