Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeScript fixes #658

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix: TypeScript fixes #658

merged 2 commits into from
Nov 24, 2023

Conversation

that-richan
Copy link
Contributor

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable

No tests needed. Docs need no change.

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes failed compilation when moduleResolution is set to nodenext by updating the tsconfig to use it.
Also enabled verbatimModuleSyntax to get rid of some warnings.

  • What is the new behavior (if this is a feature change)?

Not applicable.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)

To my knowledge, none. The updated packages already use ESM, so there should be no breaking change.

  • Other information:

Copy link

changeset-bot bot commented Nov 24, 2023

🦋 Changeset detected

Latest commit: 49523f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
imagetools-core Patch
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@that-richan that-richan changed the title Corrected TypeScript imports to pass compilation under "moduleResolution": "nodenext" and "verbatimModuleSyntax": true fix: TypeScript fixes Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (960f906) 93.60% compared to head (49523f1) 93.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          32       32           
  Lines        1188     1188           
  Branches      188      188           
=======================================
  Hits         1112     1112           
  Misses         76       76           
Flag Coverage Δ
imagetools-core 97.01% <100.00%> (ø)
vite-imagetools 78.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benmccann benmccann merged commit e0ba6c0 into JonasKruckenberg:main Nov 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants