Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support files with spaces in generateImageID #669

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

pzerelles
Copy link
Contributor

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)

  • Other information:

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: fc62a41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pzerelles pzerelles force-pushed the stat-file-with-spaces branch from 512e405 to 3113847 Compare December 8, 2023 14:37
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (22ad3a9) 93.60% compared to head (3113847) 93.60%.

❗ Current head 3113847 differs from pull request most recent head fc62a41. Consider uploading reports for the commit fc62a41 to get more accurate results

Files Patch % Lines
packages/vite/src/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          32       32           
  Lines        1189     1189           
  Branches      189      189           
=======================================
  Hits         1113     1113           
  Misses         76       76           
Flag Coverage Δ
imagetools-core 97.01% <ø> (ø)
vite-imagetools 78.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benmccann benmccann mentioned this pull request Dec 10, 2023
4 tasks
@benmccann
Copy link
Collaborator

@pzerelles is this PR still necessary if vitejs/vite#15311 is merged?

@pzerelles
Copy link
Contributor Author

@pzerelles is this PR still necessary if vitejs/vite#15311 is merged?

Yes

@benmccann benmccann changed the title fix: generateImageID failed for files with spaces fix: support files with spaces in generateImageID Dec 19, 2023
@benmccann benmccann merged commit 1bdfe74 into JonasKruckenberg:main Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants