PEP 621 and refactorisation #203
Conversation
|
Yeah, could you, please, remove the poetry part? |
|
Btw, merging such large changes can cause another xz-utils) I need to find time to review all of this. |
| wget https://bootstrap.pypa.io/pip/2.7/get-pip.py | ||
| python2 get-pip.py | ||
| rm get-pip.py | ||
| python2 -m pip install --upgrade setuptools wheel importlib_metadata |
There was a problem hiding this comment.
We still want to support Python2
Is the quick polish has been automatically generated? |
| RUN="python3 ../ROPgadget.py" | ||
| fi | ||
|
|
||
| RUN="python3 -m ropgadget" |
There was a problem hiding this comment.
we should not run globally installed module
|
|
||
| import ropgadget | ||
|
|
||
| ropgadget.main() |
There was a problem hiding this comment.
why do you remove this script?
There was a problem hiding this comment.
For compliance and modern python3 project structure. The goal is to fit the PEP 621 by having a cleaner structure with pyproject.toml that will fit all the needs 😄! It allows us to use tools such as pipx or just even pip install . inside the project and have a perfect ropgadget in our environment.
Not at all, 1h30 for the main things + a run of |
Poetry makes it really easy to manage and update project dependencies. Instead of manually editing |
Totally understand! I don't want to add extra work for you. If testing these changes becomes too complicated, feel free to close the request. My main intention was just to help lighten your load! |
Hello to the maintainers of this great project! 👋
I had to use this project and I wanted to take advantage of it to help you comply with Python3 project standards. From now on, it will be easier and more consistent to install your tool. Cross-platform installation is easy and is handled by Python itself. Which could be interesting for a possible future use for a ROP chain on Windows, who knows the future!
I didn't take the time to refactor all the code to follow all the best practices, I just wanted to give it a quick polish. 🧼
If you're not comfortable with
poetry, just ignore it. But you should know that publishing a package is very easy with this tool: https://python-poetry.org/docs/cli#publishHope it will suits your needs.
Best regards