Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): add autoupdate functionality #88

Merged
merged 11 commits into from
Dec 18, 2023
Merged

(feat): add autoupdate functionality #88

merged 11 commits into from
Dec 18, 2023

Conversation

traktuner
Copy link
Collaborator

@traktuner traktuner commented Dec 14, 2023 •
edited
Loading

Scope of this PR:

  • ability to auto-update the container on-start
  • by default, a known-good version will be used
  • by adding the environment variable "FORCE_LATEST_UPDATE=true" the latest available backblaze version will be installed
  • pin wine version in the Dockerfiles to get more control over stability
  • completely disable the update function with an environment variable

Fixes #5
Fixes #46
Fixes #31

@traktuner
add autoupdate functionality
458a7dc
@traktuner
Dockerfiles:
2b2672a 
pinned wine version 8.0.2 for ubuntu20+ubuntu22
pinned wine version 8.0.1 for ubuntu18 (no 8.0.2 available)

PINNED_BZ_VERSION:
includes the backblaze installer version from the archive.org + download link

RELEASE_VERSION:
includes the actual GitHub release version used for the custom user agent

startapp.sh:
was adapted to use the pinned backblaze version as a default.
this can be overriden by the envirtonment variable
FORCE_LATEST_UPDATE=true - then the local version gets compared to the latest backblaze version (+ download from backblaze directly instead of archive.org)
this behaviour was also applied to the initial app setup.
@traktuner
add DISABLE_AUTOUPDATE function via environment variable
fd9d59f 
(default false via Dockerfile)
DISABLE_AUTOUPDATE is only relevant for existing installs,
new installations will only respect the value of FORCE_LATEST_UPDATE

fix log_file path location to be outside, not inside the container

disclaimer_updatemode also logs if autoupdate is disabled
@traktuner
better logging
7e7d443
@traktuner traktuner marked this pull request as ready for review December 18, 2023 14:50
JonathanTreffler
JonathanTreffler approved these changes Dec 18, 2023
View reviewed changes
Copy link
Owner

@JonathanTreffler JonathanTreffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, great work.
If you are confident you have tested it enough (I changed it to a brand new installer snapshot, so that could have theoretically broken it) you can merge it yourself and I will create a new release.

@traktuner
Copy link
Collaborator Author

Thank you!
I will test it with the new installer again. Should be the same version since this is already the latest one 👍

@JonathanTreffler
Copy link
Owner

I will test it with the new installer again. Should be the same version since this is already the latest one 👍

You are correct, the new snapshot is also 9.0.0.749

$ exiftool install_backblaze.exe 
File Name                       : install_backblaze.exe
Directory                       : .
File Size                       : 29 MB
File Type                       : Win32 EXE
File Type Extension             : exe
MIME Type                       : application/octet-stream
Machine Type                    : Intel 386 or later, and compatibles
Time Stamp                      : 2023:11:03 21:22:12+01:00
Image File Characteristics      : No relocs, Executable, 32-bit
PE Type                         : PE32
Linker Version                  : 14.16
Code Size                       : 258560
Initialized Data Size           : 172544
Uninitialized Data Size         : 0
Entry Point                     : 0xcd3b
OS Version                      : 6.0
Image Version                   : 0.0
Subsystem Version               : 6.0
Subsystem                       : Windows GUI
File Version Number             : 9.0.0.749
Product Version Number          : 9.0.0.749
File Flags Mask                 : 0x003f
File Flags                      : (none)
File OS                         : Win32
Object File Type                : Executable application
File Subtype                    : 0
Language Code                   : English (U.S.)
Character Set                   : Unicode
Company Name                    : Backblaze
File Description                : 
File Version                    : 9.0.0.749
Legal Copyright                 : Copyright © 2007-2023. Backblaze
Product Name                    : Backblaze Backup
Product Version                 : 9.0.0.749

@JonathanTreffler
Copy link
Owner

I'll merge it myself, because I want to add some other changes before the release, that don't make sense in this branch, but depend on these changes. But I will wait for your OK in terms of testing for the release.

@JonathanTreffler JonathanTreffler merged commit 2482d83 into main Dec 18, 2023
4 checks passed
@traktuner
Copy link
Collaborator Author

All good with the new archive.org url!
Go for release 👍

@traktuner traktuner deleted the feat/autoupdate branch December 18, 2023 18:56
@johnnyfleet johnnyfleet mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanTreffler JonathanTreffler JonathanTreffler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@traktuner @JonathanTreffler