Payload HTTP server backend recipe #226
Conversation
recipes/PayloadHttpApiNode/README.md
Outdated
| # PayloadHttpApiNode | ||
|
|
||
| Implements a simple 'quote' API using the [payload](https://github.com/hoodunit/purescript-payload) | ||
| HTTP backend. |
There was a problem hiding this comment.
Since this is on line 4, it won't be included when you run make readme. Remove the newline and let the text wrap.
There was a problem hiding this comment.
Also, could you add something in its description that says this has similar design principles as Haskell's Servant?
| @@ -0,0 +1,2 @@ | |||
| This file just indicates that the node backend is supported. | |||
There was a problem hiding this comment.
This file should be named nodeSupportedSkipCI.md. Otherwise, CI will run this code and it will never terminate.
Yeah, that's fine! It's what I would do, too, in this situation. Looks good to me! |
|
PR was merged in package-sets, just need to wait for a new tag to get published. |
|
Looks like payload is now included in the recent package set release. @Vladciobanu could you update this PR to use the latest release? |
|
Looks like you accidentally added a |
|
I accidentally commited the modified package.json file; I'll revert and fix it. |
|
Thanks for all your work on this! |
Fixes #225
This currently overrides the packages.dhall additions for it to work. I created a PR on package-set to add it there purescript/package-sets#675
Is it okay if this just stays open until then? If not, feel free to close and I can re-open.