Skip to content

Commit

Permalink
NO-ISSUE: start script on extended-services-java should not requi…
Browse files Browse the repository at this point in the history
…re Docker (apache#2043)
  • Loading branch information
Josephblt authored Nov 10, 2023
1 parent fb19ee6 commit a34d0b5
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/extended-services-java/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ You can run it on developement mode:

## Parameters

<!-- - `-Dquarkus.http.host=<HOST>`: Sets the Quarkus app host, the default value is `0.0.0.0`.
- `-Dquarkus.http.port=<PORT_NUMBER>`: Sets the Quarkus app port, the default value is `21345`. -->
- `-Dquarkus.http.host=<HOST>` : Sets the Quarkus app host, the default value is `0.0.0.0`.
- `-Dquarkus.http.port=<PORT_NUMBER>` : Sets the Quarkus app port, the default value is `21345`.

### API

Expand Down
2 changes: 1 addition & 1 deletion packages/extended-services-java/env/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = composeEnv([require("@kie-tools/root-env/env")], {
EXTENDED_SERVICES_JAVA__host: {
default: "0.0.0.0",
description:
"Quarkus HTTP Host. Configures the IP address or host to which a Quarkus application binds for incoming HTTP requests,",
"Quarkus HTTP Host. Configures the IP address or host to which a Quarkus application binds for incoming HTTP requests.",
},
EXTENDED_SERVICES_JAVA__port: {
default: "21345",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@

quarkus.http.cors=true
quarkus.http.cors.origins=/.*/
quarkus.devservices.enabled=false

extendedServicesJava.version=${project.version}
5 changes: 0 additions & 5 deletions packages/kie-sandbox-extended-services-image/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ ARG EXTENDED_SERVICES_DEFAULT_PORT
ENV EXTENDED_SERVICES_HOST=$EXTENDED_SERVICES_DEFAULT_HOST
ENV EXTENDED_SERVICES_PORT=$EXTENDED_SERVICES_DEFAULT_PORT

RUN echo EXTENDED_SERVICES_DEFAULT_HOST: $EXTENDED_SERVICES_DEFAULT_HOST
RUN echo EXTENDED_SERVICES_DEFAULT_PORT: $EXTENDED_SERVICES_DEFAULT_PORT
RUN echo EXTENDED_SERVICES_HOST: $EXTENDED_SERVICES_HOST
RUN echo EXTENDED_SERVICES_PORT: $EXTENDED_SERVICES_PORT

RUN mkdir kie-sandbox

COPY --chown=1000:0 dist-dev/kie_sandbox_extended_services /kie-sandbox/kie_sandbox_extended_services
Expand Down
2 changes: 2 additions & 0 deletions packages/kie-sandbox-extended-services-image/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@ The service will be up at http://localhost:21345

If you need to change port or Host/IP, use the following parameters:

```bash
EXTENDED_SERVICES_HOST (Defaults to 0.0.0.0)
EXTENDED_SERVICES_PORT (Defaults to 21345)
```

For example:

Expand Down

0 comments on commit a34d0b5

Please sign in to comment.