Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modularize docker workflow #334

Merged
merged 3 commits into from
May 15, 2023
Merged

modularize docker workflow #334

merged 3 commits into from
May 15, 2023

Conversation

localagi
Copy link
Contributor

@localagi localagi commented May 14, 2023

Description

rewrote and optimized the docker workflows for daily use.
PLEASE ADD docker hub secrets for this repo (requires free acc)

Motivation and Context

see
#332
#333

How has this been tested?

on https://github.com/localagi/Agent-LLM/tree/test_update_workflow

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • My change works!

@Josh-XT Josh-XT marked this pull request as ready for review May 14, 2023 21:53
@Josh-XT
Copy link
Owner

Josh-XT commented May 14, 2023

Sorry didn't mean to change status, let me know whenever ready.

@localagi
Copy link
Contributor Author

Sorry didn't mean to change status, let me know whenever ready.

Please add the
${{ secrets.DOCKER_USERNAME }}
${{ secrets.DOCKER_PASSWORD }}

to the github repo (gear-icon settings, secrets).

Set the password to a token you create on docker hub account settings, don't use real password

A last doublenet test is running. Feel free to merge at will.

@localagi
Copy link
Contributor Author

@Josh-XT last checks done. works.

If you don't want to publish also on docker hub, we could deactivate sad noise

@localagi localagi marked this pull request as draft May 14, 2023 22:18
@localagi localagi marked this pull request as ready for review May 14, 2023 22:18
@Josh-XT Josh-XT merged commit 2120baa into Josh-XT:main May 15, 2023
1 of 3 checks passed
@localagi localagi deleted the unify_docker_workflow branch May 15, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants