Use source map (if present) to translate source file references in backtrace. #278
Conversation
…acktrace. Pass the backtrace string through a lookup function that uses a regex to extract the file path/line/col entries and replace them with ones translated by a SourceMap.
banburybill
force-pushed
the
topic/hermes_backtrace_sourcemap
branch
from
255b6f9
to
9a446dd
Compare
|
Hey @banburybill apologies for not getting to this for so long. Looking over the change, I'm not actually sure that this is code we want to introduce, because I could imagine it being somewhat finicky to maintain (regex parsing source map strings across different js engines seems dicey). My intention would be more that the uncaught exception handlers there in the EcmascriptEngine implementations should be hit quite rarely. For example, I would personally aggressively recommend using something like React's error boundaries to try to find and catch errors in js land before they ever make it to the native uncaught error handler. That way we can rely on the existing source map support in the tools we're using without having to maintain something ourselves. Have you tried using the error boundaries or similar for preventing uncaught errors in js? Edit: perhaps I should add here too that my philosophy regarding this project structure is to write absolutely the minimum amount of native C++. Anything that we can do in javascript with reasonable performance should be preferred over adding new native code to the library |
Establish framework for loading source maps if present and using them to translate references in a backtrace.
Implement this for Hermes. Use a regex to scan backtrace text and match source/line/col references. For sources where a source map is found, use the map to translate file/line/col references and substitute the translated reference into the backtrace text.
Should be easy to extend to DukTape given knowledge of DukTape backtrace formatting.
Fixes #277