Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitBook links and reference to the repo #290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/Debugging_With_Duktape.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The following option should be added to the `output` key in your webpack config:
You also need to ensure that your bundle is not minified, this can be achieved by building your JS bundle with `webpack --mode=development`.
In the case of the `GainPlugin` example this can be achieved by running `npm run start` in `GainPlugin/jsui`.

The `webpack.config.js` template provided by React-JUCE enables all of this for you. See: [Starting a new Project](New_Project.md) for a project
The `webpack.config.js` template provided by React-JUCE enables all of this for you. See: [Starting a new Project](Integrating_Your_Project.md) for a project
template setup which includes debugger support. Project template files are available under `react-juce/packages/react-juce/template`.

Example `webpack.config.js`:
Expand Down
6 changes: 3 additions & 3 deletions docs/guides/Getting_Started.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@ itself. React-JUCE's git repository contains necessary submodules, so we'll need
collect those as well, which we can do one of two ways:

```bash
$ git clone --recurse-submodules [email protected]:nick-thompson/react-juce.git
$ git clone --recurse-submodules [email protected]:JoshMarler/react-juce.git
```

or

```bash
$ git clone [email protected]:nick-thompson/react-juce.git
$ git clone [email protected]:JoshMarler/react-juce.git
$ cd react-juce
$ git submodule update --init --recursive
```

Note that the `[email protected]` prefix here indicates cloning via SSH. If you prefer
to work with git via HTTPS you'll want to swap in `https://github.com/nick-thompson/react-juce.git`
to work with git via HTTPS you'll want to swap in `https://github.com/JoshMarler/react-juce`
in the above commands.

At this point, we've got everything ready to get our project up and running. Let's
Expand Down
6 changes: 3 additions & 3 deletions docs/guides/Running_the_Examples.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ To get the GainPlugin up and running for the first time, we have to first perfor
that compilation step. So, from the root of the `React-JUCE` git repository:

```bash
$ cd examples/GainPlugin/Source/jsui/
$ cd examples/GainPlugin/jsui/
```

The `jsui/` directory here is the top level directory of all the
Expand All @@ -39,7 +39,7 @@ $ npm install
$ npm run build
```

At this point, you'll see an output file in `examples/GainPlugin/Source/jsui/build/js/`. That file location is important, because that's where the native code looks for executing the output file.
At this point, you'll see an output file in `examples/GainPlugin/jsui/build/js/`. That file location is important, because that's where the native code looks for executing the output file.

### Native

Expand Down Expand Up @@ -67,4 +67,4 @@ and redraw your interface.

Now that you're up and running, take a minute to tweak the GainPlugin React
application to get a sense of the workflow! When you're done, let's move on to
the next step, [adding React-JUCE to your own project](New_Project.md).
the next step, [adding React-JUCE to your own project](Integrating_Your_Project.md).
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/nick-thompson/react-juce.git"
"url": "git+https://github.com/JoshMarler/react-juce.git"
},
"devDependencies": {
"husky": "^4.3.8",
Expand Down