Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: overhaul for scripts and their end-to-end tests #1187

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 3, 2024

PR Checklist

Overview

Adds some inline comments to end-to-end tests, as well as a more full description of what to do with migration snapshots in development docs. Also simplifies the migration test error to suggest looking at the docs.

Touches a little bit on what #1045 requests around more clear and standardized token docs.

Co-authored-by: John Reilly [email protected]
Co-authored-by: Mohammad Bagher Abiyat [email protected]

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b2d425) 94.61% compared to head (821bbdb) 94.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   94.61%   94.68%   +0.07%     
==========================================
  Files          99      102       +3     
  Lines        5666     5685      +19     
  Branches      466      466              
==========================================
+ Hits         5361     5383      +22     
+ Misses        304      301       -3     
  Partials        1        1              
Flag Coverage Δ
create 70.30% <93.61%> (+0.10%) ⬆️
initialize 42.50% <29.78%> (+0.08%) ⬆️
migrate 69.85% <93.61%> (+0.10%) ⬆️
unit 73.70% <93.61%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: overhaul and re-document end-to-end tests docs: overhaul and re-document end-to-end test docs Jan 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: overhaul and re-document end-to-end test docs docs: overhaul for scripts and their end-to-end tests Jan 3, 2024
docs/Creation.md Outdated Show resolved Hide resolved
.github/DEVELOPMENT.md Show resolved Hide resolved
@JoshuaKGoldberg
Copy link
Owner Author

Okie dokie, thanks for the suggestions! I'm going to merge this now to get the docs improvements in. If there are more suggestions you'd want to make feel free to file an issue or just send a PR (either or both, whatever's easier for you). These things are tricky 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6f58d7f into main Jan 4, 2024
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the overhaul-e2e-tests branch January 4, 2024 18:18
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @gmail.com> for doc.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

Could not find the user gmail.com> on github.

@JoshuaKGoldberg
Copy link
Owner Author

Copy link

github-actions bot commented Jan 6, 2024

🎉 This is included in version v1.52.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants