Project system #23
Draft
Project system #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazardousPeach
force-pushed
the
project-system
branch
from
7a5efc5
to
59534ee
Compare
The fs_icon_path variable is never used in this function, and validateIndex is called at the top of the function and won't let the rest run if it returns false.
Is just visual so far though, can't do anything with it.
Also, it turns out there was already a member variable for tracking the selection, so remove the one I added and use that instead.
This code assumed that the user had exclusive control over the size and position of all windows. While this is generally true of most window managers, for users with a tiling window manager, this meant that the code was constantly fighting the window manager for control, causing the window to flash back and forth between multiple places. The fix is to not assume that m_is_resized == (window->size != m_prev_size), and instead only try to set the size once when m_is_resized is set to true, and the same for m_is_repositioned and positions.
* New clipboard api for linux * Fix some formatting stuff * Add a bunch of comments and refactor a bit * Remove unused undeclared function * Adhere windows implementaiton to new clipboard api * Add getFiles to Windows * Oops weird backslash * Fix incorrect reservation of paths vector * Use references in more places * Simplify this weird conversion back and forth code
I swear my VS in VM compiled fine before this, but these are definitely problems.
…Toolbox into project-system
* Outline new item window * Fix wrong file modified * Some things * Idk more stuff * Update gitignore * Button behavior is underlaying? * Fix rendering issues * Add idea of context path for convenient saving * Adjust code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds project awareness and interaction.