feature: allow to hide tag history to simplify the user interface #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your contribution, I think you're right, you should rename the variable to |
|
okay, thank you for the feedback. This will be be the first "default true" config, but i think i can make it happen. Will update this PR. |
I would like to use docker-registry-ui to inform users about the available tags for our images. The users of this interface are not interested in the technical backgrounds how it works and I worry that it would confuse them. Note: One needs to be aware, that this is data is available nonetheless. This is only a user interface switch for hiding the button.
lukengda
force-pushed
the
feature/allow-hide-tag-history
branch
from
bd84d74
to
e470fed
Compare
|
I reversed the logic and called it |
Joxit
approved these changes
Mar 14, 2024
Joxit
reviewed
Mar 14, 2024
| @@ -119,7 +119,7 @@ Some env options are available for use this interface for **only one server** (w | |||
| - `CATALOG_MAX_BRANCHES`: Set the maximum repository/namespace to expand (e.g. `joxit/docker-registry-ui` `joxit/` is the repository/namespace). Can be 0 to disable branching. (see [#319](https://github.com/Joxit/docker-registry-ui/pull/319)). (default: `1`). Since 2.5.0 | |||
| - `TAGLIST_PAGE_SIZE`: Set the number of tags to display in one page. (default: `100`). Since 2.5.0 | |||
| - `REGISTRY_SECURED`: By default, the UI will check on every requests if your registry is secured or not (you will see `401` responses in your console). Set to `true` if your registry uses Basic Authentication and divide by two the number of call to your registry. (default `false`). Since 2.5.0 | |||
|
|
|||
| - `SHOW_TAG_HISTORY`: Whether to show the tag history feature or not. Allows to simplify the user interface by hiding it form the tag list if set to `false`. (default: `true`). | |||
There was a problem hiding this comment.
You text is a way to much subjective "Allows to simplify the user interface". I will change it before the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use docker-registry-ui to inform users about the available tags for our images. The users of this interface are not interested in the technical backgrounds how it works and I worry that it would confuse them.
Note: One needs to be aware, that this is data is available nonetheless. This is only a user interface switch for hiding the button.
If desired, i could also rephrase the variables to "show-tag-history", defaulting to true, to match the name of other options.
Is there anything else that is required for the merge request?
Closes #358